• auzy1@lemmy.world
    link
    fedilink
    arrow-up
    3
    arrow-down
    2
    ·
    edit-2
    2 days ago

    Yeah. Pretty much.

    The actual policy is that it all gets reviewed by a human I think when I was looking into it.

    The bots are likely most useful to reject obviously bad patches which have obvious bugs or don’t follow guidelines. And identifying bad code is something which AI tends to be good at.

    In our code at work, we use weakly typed languages which aren’t strict and on those it tends to be even better. We catch things like table keys that are typed wrong, etc. On C, things like pointers it probably does a good job with identifying as wrong

    If it passes AI code review it still gets checked by human for things that are wrong and needs fixing. But if it fails, it probably needs fixing regardless.

    • Ghoelian@piefed.social
      link
      fedilink
      English
      arrow-up
      3
      ·
      2 days ago

      A good language server / ide will also complain about incorrect types. That specific example is a deterministic process, no llm is required for it at all.

      • auzy1@lemmy.world
        link
        fedilink
        arrow-up
        2
        arrow-down
        2
        ·
        edit-2
        2 days ago

        We do use one. But, in practice, they can’t catch a lot of things which AI will

        At least in our case too based on what’s available, it also can’t check stuff like coding style well (but our development relies on that less).

        Some might though

        • Ghoelian@piefed.social
          link
          fedilink
          English
          arrow-up
          2
          arrow-down
          2
          ·
          2 days ago

          I find that very hard to believe, if you’re truly just talking about typing. If this is true you’re using an awful language server / linter / whatever.

          Coding style is also a deterministic process, for which every widely used language has a linter or formatter or whatever. Also no LLMs needed.

          As a professional software developer of 8 years, I honestly have no idea what you’re talking about

          • auzy1@lemmy.world
            link
            fedilink
            arrow-up
            2
            arrow-down
            1
            ·
            2 days ago

            This is Lua code. LuaLS is basically the language server available.

            And sorry, I should have said “dynamically typed”. But, weak tables.

            There’s a lot of things that don’t get caught, such as concatenating a boolean which causes a lua error in our environment. LuaLS won’t catch that.

            Formatting isn’t a problem for us, but it does affect the kernel. But, the VSCode one we use does a lot of weird things honestly.

            • Ghoelian@piefed.social
              link
              fedilink
              English
              arrow-up
              1
              ·
              1 day ago

              I am not familiar with Lua at all, but that does just sound like a bad language server. I still don’t think the solution is AI, it’s just making a better language server.