superkret@feddit.org to Programmer Humor@programming.dev · 3 months agoBetter merge it, too!i.imgflip.comimagemessage-square24fedilinkarrow-up1675arrow-down116
arrow-up1659arrow-down1imageBetter merge it, too!i.imgflip.comsuperkret@feddit.org to Programmer Humor@programming.dev · 3 months agomessage-square24fedilink
minus-squaresteventhedev@lemmy.worldlinkfedilinkarrow-up39arrow-down1·3 months agoI have either written or gotten a variant of every single one of these comments 🫠: Please include the JIRA task in the commit title. Did you run any manual testing? Where’s the PRD link in the commit message? Can you please split this into multiple smaller commits? Can you combine these two commits? Did you email Jon about this because he’s working on that project with Sarah and you might be duplicating efforts. This should be named BarFoo instead of FooBar. Why aren’t you using CorporateInternalLib16 that does 90% of this? Why aren’t you using ThirdPartyPaidLibByExEmployee? Why aren’t you using StandardLib thing you forgot existed? All our I/O should be async. All our hot loop code needs to be sync. This will increase latency of NonCoreBusinessFlow by 0.01%. can you shave some time off so we can push in feature B also? Please add a feature flag so we can do gradual rollout. What operational levers does this have? Lgtm - just address those comments
minus-squareexpr@programming.devlinkfedilinkarrow-up22·3 months agoI dunno, plenty of those sound pretty reasonable.
I have either written or gotten a variant of every single one of these comments 🫠:
Please include the JIRA task in the commit title.
Did you run any manual testing?
Where’s the PRD link in the commit message?
Can you please split this into multiple smaller commits?
Can you combine these two commits?
Did you email Jon about this because he’s working on that project with Sarah and you might be duplicating efforts.
This should be named BarFoo instead of FooBar.
Why aren’t you using CorporateInternalLib16 that does 90% of this?
Why aren’t you using ThirdPartyPaidLibByExEmployee?
Why aren’t you using StandardLib thing you forgot existed?
All our I/O should be async.
All our hot loop code needs to be sync.
This will increase latency of NonCoreBusinessFlow by 0.01%. can you shave some time off so we can push in feature B also?
Please add a feature flag so we can do gradual rollout.
What operational levers does this have?
Lgtm - just address those comments
I dunno, plenty of those sound pretty reasonable.