Remove these blank lines.
I’m not seeing unit tests for this.
Unnecessary comment.
BLAM
Ow! Also, this could’ve been a smaller calibur.
The second one is very valid. Please do not waste my time without having a prove about your functionality.
LGTM (lunatic gunner targeting me)
I have either written or gotten a variant of every single one of these comments 🫠:
Please include the JIRA task in the commit title.
Did you run any manual testing?
Where’s the PRD link in the commit message?
Can you please split this into multiple smaller commits?
Can you combine these two commits?
Did you email Jon about this because he’s working on that project with Sarah and you might be duplicating efforts.
This should be named BarFoo instead of FooBar.
Why aren’t you using CorporateInternalLib16 that does 90% of this?
Why aren’t you using ThirdPartyPaidLibByExEmployee?
Why aren’t you using StandardLib thing you forgot existed?
All our I/O should be async.
All our hot loop code needs to be sync.
This will increase latency of NonCoreBusinessFlow by 0.01%. can you shave some time off so we can push in feature B also?
Please add a feature flag so we can do gradual rollout.
What operational levers does this have?
Lgtm - just address those comments
I dunno, plenty of those sound pretty reasonable.
lgtm
lunatic girl threatening me
Let’s gamble, try merging
The number of comments is inversely proportional to the size of the pull request.
Yet the review time is exponential with the size.
https://github.com/ZILtoid1991
Please, do pull requests on my projects! I might even accept them.
You realy want the D don’t you
gigachad_yes.gif
First problem is she’s expecting a right boob like me to review her pull request. Second problem is I don’t give a shit.
i don’t understand it, am i missing some context here?
The meme format implies she catfished you with the promise of “Netflix and chill” at her house only to pull a gun on you.
In particular, she wants you to review and merge that goddamn pull request she made to your open source project repo two months ago that finally fixes that one really annoying bug.
What is the original source material for the image and the name of the woman within?
This is the artist, if you can excuse a link to X which I found on reddit via google.
…
I feel dirty.
Edit: Here’s a KYM article. No idea why I didn’t find it on my first sweep. It might have something to do with google being absolute dogshit these days.
Thanks bro
Also I think that’s Note wearing a TempleOS shirt in the background of this other post by the artist.
origin of meme with this text:
https://www.instagram.com/p/B1jIa-TifY8/origin of this version of the meme:
https://x.com/whoismonday/status/1529566283401834496Thanks, comrade
Takes on a slightly different meaning in the context of XZ utils
Babe, you turn me (O)n
:+1: