• Quetzalcutlass@lemmy.world
    link
    fedilink
    English
    arrow-up
    8
    arrow-down
    7
    ·
    1 month ago

    Except those imports were used by a huge section of code you temporarily commented out, and now you’ll need to manually select a dozen imports to get it working again when you come back to it.

    (Sure you could have just commented out the unused imports, but the linter auto-sorted them and you’re feeling too lazy to copy-paste a dozen scattered lines)

    • CameronDev@programming.dev
      link
      fedilink
      arrow-up
      11
      ·
      1 month ago

      Use a good IDE, and readding the imports is pretty easy.

      I find commented code to be a bit of a smell on its own, just delete it, and if you really need it again, dig it out of source control.

      • jjjalljs@ttrpg.network
        link
        fedilink
        arrow-up
        8
        ·
        1 month ago

        Yeah. My last job, a PR with commented out code typically wouldn’t get approved. Either leave it in version history, or stick it on a branch

    • mmddmm@lemm.ee
      link
      fedilink
      arrow-up
      6
      ·
      1 month ago

      Hum… Ignore linter advice for code that you temporarily mangled.

      It’s not like you have to act upon it as soon as a blue line appears under your code.

      • bleistift2@sopuli.xyz
        link
        fedilink
        English
        arrow-up
        0
        ·
        1 month ago

        Depending on the configuration, a linter may cause the compilation or a CI pipeline to fail.

        • mmddmm@lemm.ee
          link
          fedilink
          arrow-up
          1
          ·
          1 month ago

          Failing your local compilation due to linter problems is just stupid.

          Sending “temporary” changes into your CI pipeline isn’t even stupid, it’s borderline malicious.

          • bleistift2@sopuli.xyz
            link
            fedilink
            English
            arrow-up
            1
            ·
            1 month ago

            Sending “temporary” changes into your CI pipeline isn’t even stupid, it’s borderline malicious.

            No? “Hey customer, I’ve deployed the changes you requested to the staging area. Is this what you had in mind? Keep in mind it only looks good and isn’t fully functional yet.”

    • CaptDust@sh.itjust.works
      link
      fedilink
      arrow-up
      2
      arrow-down
      1
      ·
      1 month ago

      Honestly I’ll disable linting across entire files during these kinds of refactors because it’s annoying having build output littered with unused imports and format warnings while I’m still working on a solution. Requires some extra diligence to re-enable and clean up before pushing though.