Just take the string as bytes and hash it ffs

    • CosmicTurtle0@lemmy.dbzer0.com
      link
      fedilink
      English
      arrow-up
      59
      arrow-down
      10
      ·
      4 months ago

      I sort of get it. You don’t want to allow the entire work of Shakespeare in the text field, even if your database can handle it.

      16 characters is too low. I’d say a good upper limit would be 100, maybe 255 if you’re feeling generous.

      • owsei@programming.dev
        link
        fedilink
        English
        arrow-up
        78
        arrow-down
        2
        ·
        4 months ago

        The problem is that you (hopefully) hash the passwords, so they all end up with the same length.

        • expr@programming.dev
          link
          fedilink
          English
          arrow-up
          49
          ·
          4 months ago

          At minimum you need to limit the request size to avoid DOS attacks and such. But obviously that would be a much larger limit than anyone would use for a password.

        • Carighan Maconar@lemmy.world
          link
          fedilink
          English
          arrow-up
          5
          arrow-down
          15
          ·
          4 months ago

          And sure, in theory your hashing browser-side could break if you do that. Depending on how much text the user pastes in. But at that point, it’s no longer your problem but the browser’s. 🦹

          • owsei@programming.dev
            link
            fedilink
            English
            arrow-up
            19
            ·
            4 months ago

            Why are you hasing in the browser?

            Also, what hashing algorithm would break with large input?

              • owsei@programming.dev
                link
                fedilink
                English
                arrow-up
                4
                arrow-down
                1
                ·
                4 months ago

                Damm, I legit didn’t knew there bcrypt had a length limit! Thank you for another reason not to use bcrypt

              • Swedneck@discuss.tchncs.de
                link
                fedilink
                English
                arrow-up
                1
                ·
                4 months ago

                wouldn’t you then just break it up into chunks of 72 bytes, hash them individually, and concatenate the hashes? And if that’s still too long, split the hash into 72 byte chunks and repeat until it’s short enough?

                • yhvr@lemm.ee
                  link
                  fedilink
                  English
                  arrow-up
                  2
                  ·
                  4 months ago

                  I don’t know the specifics behind why the limit is 72 bytes, but that might be slightly tricky. My understanding of bcrypt is that it generates 2^salt different possible hashes for the same password, and when you want to test an input you have to hash the password 2^salt times to see if any match. So computation times would get very big if you’re combining hashes

              • candybrie@lemmy.world
                link
                fedilink
                English
                arrow-up
                19
                arrow-down
                1
                ·
                edit-2
                4 months ago

                Because then the hash is the password. Someone could just send the hash instead of trying to find a password that gets the correct hash. You can’t trust the client that much.

                You can hash the password on both sides to make it work; though I’m not sure why you’d want to. I’m not sure what attack never having the plain text password on the server would prevent. Maybe some protection for MITM with password reuse?

              • CommanderCloon@lemmy.ml
                link
                fedilink
                English
                arrow-up
                7
                arrow-down
                1
                ·
                4 months ago

                Because then that means you don’t salt your hashes, or that you distribute your salt to the browser for the hash. That’s bad.

          • CommanderCloon@lemmy.ml
            link
            fedilink
            English
            arrow-up
            6
            ·
            4 months ago

            If you hash in the browser it means you don’t salt your hash. You should absolutely salt your hash, not doing so makes your hashes very little better than plaintext.

            • Shadow@lemmy.ca
              link
              fedilink
              English
              arrow-up
              5
              arrow-down
              1
              ·
              edit-2
              4 months ago

              There’s nothing stopping a browser from salting a hash. Salts don’t need to be kept secret, but it should be a new random salt per user.

      • Chris@feddit.uk
        link
        fedilink
        English
        arrow-up
        21
        arrow-down
        1
        ·
        4 months ago

        The eBay password limit is 256 characters.

        They made the mistake of mentioning this when I went to change my password.

        Guess how many characters my eBay password has?

      • Discover5164@lemm.ee
        link
        fedilink
        English
        arrow-up
        3
        ·
        4 months ago

        the password cannot contains the same sequences of characters as the old password.

        and i have seen this requirement in a service that requires changing it every month for some reasons.

        and this is to manage a government digital identity that allows to log it in all governments websites.

        • PM_me_your_doggo@lemmy.world
          link
          fedilink
          English
          arrow-up
          2
          ·
          edit-2
          4 months ago

          the password cannot contains the same sequences of characters as the old password.

          That’s a weird way to say “we store your password in plaintext”

      • CaptPretentious@lemmy.world
        link
        fedilink
        English
        arrow-up
        3
        ·
        4 months ago

        Yep. Having to have requirements that doesn’t flow with people very well and requiring constant updates, people WILL find shortcuts. In the office, I’ve seen sheets of paper with the password written down, I’ve seen sticky notes, I’ve seen people put them in notepad/word so they could just copy paste.

        This is made worse, because you have to go out of your way for a password manager, which means you need to know what that is. And you need a good one because there has been (and I’m going to generalize here) problems with some password managers in the past. And for work, they have to allow a password manager for that to even be an option. Which you then end up with this security theater.

        • rekabis@lemmy.ca
          link
          fedilink
          English
          arrow-up
          3
          ·
          4 months ago

          And you need a good one because there has been problems with some password managers in the past.

          coughLastPasscough

          “Problems”. What an delightfully understated term to use.

    • Showroom7561@lemmy.ca
      link
      fedilink
      English
      arrow-up
      17
      ·
      4 months ago

      Reasonable upper limits are OK. But FFS, the limit should be enough to have a passphrase with 4 or 5 words in it.

      • aname@lemmy.one
        link
        fedilink
        English
        arrow-up
        6
        ·
        4 months ago

        Usually 256 bit hash is used. 256 bits is 32 bytes or 32 characters. Of course you are losing some entropy because character set is limited, but 32 characters is beyond reasonable anyway.

        • Lojcs@lemm.ee
          link
          fedilink
          English
          arrow-up
          5
          ·
          edit-2
          4 months ago

          The eff passphrase generator has about 2.5 bits of entropy per character (without word separators). Eff recommends 6 word passphrases, and with an avg word length of 7, that’s (only) 79.45 bits of entropy that won’t even fit in the 32 characters. If there wasn’t a password length limit it would be possible to saturate the hash entropy with a 20+ word & 102+ char passphrase.

          • aname@lemmy.one
            link
            fedilink
            English
            arrow-up
            1
            ·
            4 months ago

            Of course, but that’s because you are using a passphrases. Passwords have a much hogher entropy.

        • Showroom7561@lemmy.ca
          link
          fedilink
          English
          arrow-up
          3
          ·
          4 months ago

          I’d be totally fine woth 32 characters! But I’ve come across too many websites with unreasonably short (20 characters or less) limits.

    • needanke@feddit.org
      link
      fedilink
      English
      arrow-up
      10
      arrow-down
      3
      ·
      4 months ago

      Just opened a PayPal account and their limit is 20. Plus the only 2fa option is sms 🙃.

    • rekabis@lemmy.ca
      link
      fedilink
      English
      arrow-up
      3
      arrow-down
      1
      ·
      4 months ago

      Especially since it takes more effort to limit it than leave it wide open for whatever length of password a user wants to use.

      nvarchar(max) is perfect to store the hashed copy.